Ensuring stdio transport closure despite server hanging. Fixing #271 #314
+82
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
reviewed
Apr 11, 2025
|
@Skn0tt thanks, you are right, pushed a more graceful exit. |
Skn0tt
reviewed
Apr 11, 2025
Skn0tt
reviewed
Apr 15, 2025
There was a problem hiding this comment.
After sleeping a couple nights over this, i'm not convinced this PR is the right approach. The gist of #271 is that close() doesn't block until the process is closed. This PR doesn't adress that, but instead adds graceful shutdown, which is a different issue. Before we implement graceful shutdown, I think we should coordinate with the project maintainers in a separate issue.
9 tasks
|
I gave it a go myself: #821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force closing the child process upon closing the stdio process
Motivation and Context
The issue was raised and reproducible in #271
How Has This Been Tested?
Added a manual test + tried adding the scenario from the issue with Microsoft's playwright-mcp
Breaking Changes
None
Types of changes
Checklist
Additional context
StdioClientTransport#close()does not wait until underlying process is closed #271close()beforebrowser_closetool is called microsoft/playwright-mcp#141